Re: [PATCH 08/27] xfs: kill xfs_itruncate_start

Alex Elder
2011-06-29T22:13:37Z

On Wed, 2011-06-29 at 10:01 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-kill-xfs_itruncate_start)
> xfs_itruncate_start is a rather length wrapper that evaluates to a call
> to xfs_ioend_wait and xfs_tosspages, and only has two callers.
>
> Instead of using the complicated checks left over from IRIX where we
> can to truncate the pagecache just call xfs_tosspages
> (aka truncate_inode_pages) directly as we want to get rid of all data
> after i_size, and truncate_inode_pages handles incorrect alignments
> and too large offsets just fine.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>

Nice cleanup. Looks good.

I will continue reviewing this series tomorrow.

Reviewed-by: Alex Elder <aelder@sgi.com>