From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p663mhVE064313 for ; Tue, 5 Jul 2011 22:48:43 -0500 Received: from ipmail06.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 137E31BF6E0F for ; Tue, 5 Jul 2011 20:48:42 -0700 (PDT) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id n5PFaUvNl2cOgKHd for ; Tue, 05 Jul 2011 20:48:42 -0700 (PDT) Date: Wed, 6 Jul 2011 13:48:40 +1000 From: Dave Chinner Subject: Re: [PATCH 25/27] xfs: return the buffer locked from xfs_buf_get_uncached Message-ID: <20110706034840.GT1026@dastard> References: <20110701094321.936534538@bombadil.infradead.org> <20110701094607.356791525@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110701094607.356791525@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Fri, Jul 01, 2011 at 05:43:46AM -0400, Christoph Hellwig wrote: > All other xfs_buf_get/read-like helpers return the buffer locked, make sure > xfs_buf_get_uncached isn't different for no reason. Half of the callers > already lock it directly after, and the others probably should also keep > it locked if only for consistency and beeing able to use xfs_buf_rele, > but I'll leave that for later. > > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs