Re: [PATCH 15/27] xfs: kill struct xfs_dir2_sf

Dave Chinner
2011-06-30T07:04:54Z

On Wed, Jun 29, 2011 at 10:01:24AM -0400, Christoph Hellwig wrote:
> The list field of it is never cactually used, so all uses can simply be
> replaced with the xfs_dir2_sf_hdr_t type that it has as first member.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

I can't help but think this would have been a much smaller patch if
you rolled the contents of the xfs_dir2_sf_hdr_t into xfs_dir2_sf_t
and killed the xfs_dir2_sf_hdr_t instead. There's many more
occurrences of xfs_dir2_sf_t than there are xfs_dir2_sf_hdr_t.

Anyway, gotta run now so I'll look at this more later....

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com