Re: [PATCH 15/27] xfs: cleanup the defintion of struct xfs_dir2_sf_entry

Alex Elder
2011-07-06T03:33:33Z

On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote:
> Remove the inumber member which is at a variable offset after the actual
> name, and make name a real variable sized C99 array instead of the incorrect
> one-sized array which confuses (not only) gcc. Based on this clean up
> the helpers to calculate the entry size.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Why was the inode put after then name in the
first place?

Anyway, looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>