Re: [PATCH 26/27] xfs: cleanup I/O-related buffer flags

Christoph Hellwig
2011-07-06T09:11:20Z

On Wed, Jul 06, 2011 at 01:54:11PM +1000, Dave Chinner wrote:
> Is it worthwhile tagging all these as READ_META and WRITE_META?
> Though that probably needs to be done as a separate commit...

Right now they preempt synchronous writes, which is not something we
want. There is a patch out on lkml removing that hack, at which point
we should tag them as _META to make blktrace output more useful.

> > /* flags used only internally */
> > -#define _XBF_PAGES (1 << 18)/* backed by refcounted pages */
> > -#define _XBF_RUN_QUEUES (1 << 19)/* run block device task queue */
> > -#define _XBF_KMEM (1 << 20)/* backed by heap memory */
> > -#define _XBF_DELWRI_Q (1 << 21)/* buffer on delwri queue */
> > +#define _XBF_PAGES (1 << 20)/* backed by refcounted pages */
> > +#define _XBF_KMEM (1 << 21)/* backed by heap memory */
> > +#define _XBF_DELWRI_Q (1 << 22)/* buffer on delwri queue */
>
> Might be worthwhile cleaning up the stray tab before _XBF_KMEM
> there.

done.