From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p668jpuv095367 for ; Wed, 6 Jul 2011 03:45:51 -0500 Date: Wed, 6 Jul 2011 04:45:49 -0400 From: Christoph Hellwig Subject: Re: [PATCH 18/27] xfs: avoid usage of struct xfs_dir2_data Message-ID: <20110706084549.GG19861@infradead.org> References: <20110701094321.936534538@bombadil.infradead.org> <20110701094606.003170984@bombadil.infradead.org> <1309923502.3381.35.camel@doink> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1309923502.3381.35.camel@doink> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: Christoph Hellwig , xfs@oss.sgi.com On Tue, Jul 05, 2011 at 10:38:22PM -0500, Alex Elder wrote: > On Fri, 2011-07-01 at 05:43 -0400, Christoph Hellwig wrote: > > In most places we can simply pass around and use the struct xfs_dir2_data_hdr, > > which is the first and most important member of struct xfs_dir2_data instead > > of the full structure. > > > > Signed-off-by: Christoph Hellwig > > In xfs_dir2_data_freescan() you get the address of the > dir2_data_t by forcibly casting the address of the > header to that type. We all know that's fine, but > it's an unsavory practice. Why don't you pass the > full dir2_data_t in that case where it's needed? > Are you simply trying to avoid passing *any* pointers > to variable-sized types? I'm restricting the dir2_data_t scope to where we needed it, to kill it (and thus the cast) off entirely in the next patch. > (Update: I think you eliminate that line in the next > patch anyway...) Exactly! _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs