Re: [PATCH 2/5] xfs: use a cursor for bulk AIL insertion

Alex Elder
2011-07-07T21:26:18Z

On Mon, 2011-07-04 at 17:20 -0400, Christoph Hellwig wrote:
> FYI: the following patch implementing my suggested cleanups survived a
> few rounds of xfsqa:

It also eliminates the concern I had about using the value
of "lip" after falling off the front of the list with a
list_for_each_entry_reverse(). A null pointer signifies
no entry has a lower lsn than the one provided, and
that covers both the "empty list" and the "lower than
all other lsn's in the list" cases.

I think you should base your solution on Christoph's
approach, Dave.

-Alex