From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: Updated xfsprogs 2.6.38 merge
Date: Sun, 10 Jul 2011 17:01:13 -0400 [thread overview]
Message-ID: <20110710210113.GA14527@infradead.org> (raw)
In-Reply-To: <20110705024855.GA561@dastard>
On Tue, Jul 05, 2011 at 12:48:55PM +1000, Dave Chinner wrote:
> Folks,
>
> I pushed out an updated 2.6.38 kernel merge to xfsprogs patchset a
> couple of days ago. I've been doing quite a bit of testing on it,
> both 32 bit and 64 bit, with 512 byte, 1k and 4k block size
> filesystems and I haven't come across any regressions. The patchset
> can be found here:
>
> git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev kernel-2.6.38-sync
>
> It's pretty much unchanged from the last set of patches I sent,
> except for one minor fix to the radix tree code for an off by one in
> the path array size for item and tag deletes.
>
> I'm pretty much ready to commit this update so I can then move
> forward with updating it to the 3.0 kernel code base as a smaller
> incremental series.
It's still missing the fix for the xfs_imap.h removal I pointed out last
round:
Index: xfsprogs-dev/include/Makefile
===================================================================
--- xfsprogs-dev.orig/include/Makefile 2011-07-10 20:51:24.000000000 +0000
+++ xfsprogs-dev/include/Makefile 2011-07-10 20:51:31.000000000 +0000
@@ -27,7 +27,7 @@ QAHFILES = libxfs.h libxlog.h \
xfs_dir2.h xfs_dir2_block.h xfs_dir2_data.h xfs_dir2_leaf.h \
xfs_dir2_node.h xfs_dir2_sf.h xfs_dir_leaf.h xfs_dir_sf.h \
xfs_extfree_item.h xfs_ialloc.h xfs_ialloc_btree.h \
- xfs_imap.h xfs_inode.h xfs_inode_item.h xfs_inum.h \
+ xfs_inode.h xfs_inode_item.h xfs_inum.h \
xfs_log.h xfs_log_priv.h xfs_log_recover.h xfs_metadump.h \
xfs_mount.h xfs_quota.h xfs_rtalloc.h xfs_sb.h xfs_trace.h \
xfs_trans.h xfs_trans_space.h xfs_types.h xfs_dfrag.h
But even after that a simple mkfs crashed for me on 32-bit x86. Here is
the gdb backtrace:
Program received signal SIGSEGV, Segmentation fault.
0x0805736b in tag_get (root=0xffffda5c, index=0) at radix-tree.c:82
82 return 1 & (((const __uint32_t *)node->tags[tag])[offset >> 5] >> (offset & 31));
(gdb) bt
#0 0x0805736b in tag_get (root=0xffffda5c, index=0) at radix-tree.c:82
#1 radix_tree_delete (root=0xffffda5c, index=0) at radix-tree.c:726
#2 0x08054ee7 in libxfs_umount (mp=0xffffd8f8) at init.c:822
#3 0x0805277c in main (argc=3, argv=0xffffdd94) at xfs_mkfs.c:2683
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-10 21:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 2:48 Updated xfsprogs 2.6.38 merge Dave Chinner
2011-07-10 21:01 ` Christoph Hellwig [this message]
2011-07-11 0:01 ` Dave Chinner
2011-07-11 5:27 ` Christoph Hellwig
2011-07-22 15:57 ` Christoph Hellwig
2011-07-29 22:12 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110710210113.GA14527@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox