From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: hch@lst.de, xfs@oss.sgi.com
Subject: Re: [regression, 3.0-rc] xfs: freeze hang in 068
Date: Mon, 11 Jul 2011 05:51:47 -0400 [thread overview]
Message-ID: <20110711095147.GA19354@infradead.org> (raw)
In-Reply-To: <20110711010357.GD23038@dastard>
On Mon, Jul 11, 2011 at 11:03:57AM +1000, Dave Chinner wrote:
> Christoph,
>
> The recent changes to the active transaction accounting to close a
> race on freeze can hang the freeze process and hence the filesystem.
That commit isn't in 3.0-rc, but I guess it's just the subject line
that is incorrect.
> So effective we cannot sleep waiting for SB_FREEZE_TRANS to go away
> while holding an active transaction reference because the freeze
> process does not set and check SB_FREEZE_TRANS/mp->m_active_trans
> atomically.
>
> I haven't put any thought into how to solve this problem yet, so I'd
> suggest that at this late stage we need to revert 315fdfa (xfs: fix
> filesystsem freeze race in xfs_trans_alloc) because the race it
> fixes is far less critical (i.e. doesn't hang the filesystem) and
> harder to hit than the regression introduced here.
Yes, I guess we need to revert it for now.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-11 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 1:03 [regression, 3.0-rc] xfs: freeze hang in 068 Dave Chinner
2011-07-11 9:51 ` Christoph Hellwig [this message]
2011-07-12 0:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110711095147.GA19354@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox