From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p6C9CEs9023807 for ; Tue, 12 Jul 2011 04:12:14 -0500 Date: Tue, 12 Jul 2011 05:12:12 -0400 From: Christoph Hellwig Subject: Re: [PATCH 05/11] xfs: add a proper transaction pointer to struct xfs_buf Message-ID: <20110712091212.GC8364@infradead.org> References: <20110710204916.856267100@bombadil.infradead.org> <20110710205017.667546845@bombadil.infradead.org> <1310423584.7019.57.camel@doink> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1310423584.7019.57.camel@doink> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: Christoph Hellwig , xfs@oss.sgi.com On Mon, Jul 11, 2011 at 05:33:04PM -0500, Alex Elder wrote: > On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote: > > Replace the typeless b_fspriv2 and the ugly macros around it with a properly > > typed transaction pointer. > > > > Signed-off-by: Christoph Hellwig > > So it looks like you do two things. > - make it a real pointer (which it should be), when it's > used to keep track of the transaction a buffer is > associated with; and > - eliminate the use of this field storing cast 1's and 2's > for verifying the way log buffers are used. > > I don't see much value in the second one, and the first > is the way it should be, so this looks good to me. I should have mentioned that it also drops those pointless debug checks in the log code. I'll add it to the patch description. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs