Re: [PATCH 09/11] xfs: remove the dead QUOTADEBUG debug

Dave Chinner
2011-07-12T00:59:31Z

On Mon, Jul 11, 2011 at 05:33:22PM -0500, Alex Elder wrote:
> On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote:
> > Remove the dead hash table test rid which has been rotting away under
> > QUOTADEBUG, including some code that was compiled for normal debug
> > builds, but not actually called without QUOTADEBUG, and enable a few
> > cheap debug checks that were hidden under QUOTADEBUG for normal
> > debug builds.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> I've never used it and I don't suppose anyone else has
> been (or will any time soon). So I guess it might as
> well go.

I have actually used it in the past year or so, but that was only
because I changed locking and needed to verify that the QUOTADEBUG
code still worked. But if it wasn't there, i wouldn't have had to do
that, so I'm happy to see it go.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com