From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
xfs@oss.sgi.com, Alex Elder <aelder@sgi.com>
Subject: Re: [PATCH 06/11] xfs: remove wrappers around b_fspriv
Date: Tue, 12 Jul 2011 05:15:09 -0400 [thread overview]
Message-ID: <20110712091509.GD8364@infradead.org> (raw)
In-Reply-To: <20110712010257.GL23038@dastard>
On Tue, Jul 12, 2011 at 11:02:57AM +1000, Dave Chinner wrote:
> On Mon, Jul 11, 2011 at 05:33:09PM -0500, Alex Elder wrote:
> > On Sun, 2011-07-10 at 16:49 -0400, Christoph Hellwig wrote:
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > I never did understand exactly why these things
> > were macro-ized, but figured it must have hidden
> > some sort of conditional debug or development aid
> > long ago. In any case, good riddance.
>
> It was part of the original Linux port. Both the Irix and Linux XFS
> code was converted to use these XFS_BUF macros. Hence the core XFS
> code was identical on both platforms and easy to move changes from
> Irix to Linux because the macros hid the differences in buffer cache
> implementations.
That was the theory, but these portability changes never got merged
back to IRIX. On the other hand XFS/Linux actually had two different
buffer implementations in it's early days and the macros allowed
switching between them. Back then the area was an even bigger mess,
as the buffer cache implementation that survived was called pagebuf,
and used page_buf_/pb_/PB_/ prefixes, which not only got mapped to
various different and often duplicate xfs_buf or similar names.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-12 9:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 20:49 [PATCH 00/11] a few more cleanups for Linux 3.1 Christoph Hellwig
2011-07-10 20:49 ` [PATCH 01/11] xfs: reshuffle dir2 headers Christoph Hellwig
2011-07-11 22:32 ` Alex Elder
2011-07-12 9:06 ` Christoph Hellwig
2011-07-10 20:49 ` [PATCH 02/11] xfs: cleanup struct xfs_dir2_free Christoph Hellwig
2011-07-11 22:32 ` Alex Elder
2011-07-10 20:49 ` [PATCH 03/11] xfs: factor out xfs_dir2_leaf_find_stale Christoph Hellwig
2011-07-11 22:32 ` Alex Elder
2011-07-12 9:09 ` Christoph Hellwig
2011-07-13 6:49 ` Dave Chinner
2011-07-13 7:16 ` Christoph Hellwig
2011-07-13 10:28 ` Dave Chinner
2011-07-10 20:49 ` [PATCH 04/11] xfs: factor out xfs_da_grow_inode_int Christoph Hellwig
2011-07-11 0:37 ` Dave Chinner
2011-07-11 5:24 ` Christoph Hellwig
2011-07-12 0:55 ` Dave Chinner
2011-07-11 22:32 ` Alex Elder
2011-07-10 20:49 ` [PATCH 05/11] xfs: add a proper transaction pointer to struct xfs_buf Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-12 9:12 ` Christoph Hellwig
2011-07-10 20:49 ` [PATCH 06/11] xfs: remove wrappers around b_fspriv Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-12 1:02 ` Dave Chinner
2011-07-12 9:15 ` Christoph Hellwig [this message]
2011-07-10 20:49 ` [PATCH 07/11] xfs: remove wrappers around b_iodone Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-10 20:49 ` [PATCH 08/11] xfs: remove the unused xfs_buf_delwri_sort function Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-10 20:49 ` [PATCH 09/11] xfs: remove the dead QUOTADEBUG debug Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-12 0:59 ` Dave Chinner
2011-07-10 20:49 ` [PATCH 10/11] xfs: remove leftovers of the old btree tracing code Christoph Hellwig
2011-07-12 2:52 ` Alex Elder
2011-07-10 20:49 ` [PATCH 11/11] xfs: kill the dead XFS_DABUF debug code Christoph Hellwig
2011-07-11 22:33 ` Alex Elder
2011-07-13 6:51 ` [PATCH 00/11] a few more cleanups for Linux 3.1 Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110712091509.GD8364@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox