Re: [PATCH] xfs: failure mapping nfs fh to inode should return ESTALE

Alex Elder
2011-07-14T22:25:50Z

On Thu, 2011-07-14 at 16:50 -0400, J. Bruce Fields wrote:
> From: J. Bruce Fields <bfields@redhat.com>
>
> On xfs exports, nfsd is incorrectly returning ENOENT instead of ESTALE
> on attempts to use a filehandle of a deleted file (spotted with pynfs
> test PUTFH3). The ENOENT was coming from xfs_iget.
>
> (It's tempting to wonder whether we should just map all xfs_iget errors
> to ESTALE, but I don't believe so--xfs_iget can also return ENOMEM at
> least, which we wouldn't want mapped to ESTALE.)
>
> While we're at it, the other return of ENOENT in xfs_nfs_get_inode()
> also looks wrong.
>
> Signed-off-by: J. Bruce Fields <bfields@redhat.com>

Looks reasonable to me.

I'll give others a chance to weigh in, but otherwise I'll
get this in for Linux 3.1.

Reviewed-by: Alex Elder <aelder@sgi.com>