public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: introduce an allocation workqueue
Date: Tue, 19 Jul 2011 13:14:29 +1000	[thread overview]
Message-ID: <20110719031429.GM30254@dastard> (raw)
In-Reply-To: <20110719020214.GB4259@infradead.org>

On Mon, Jul 18, 2011 at 10:02:14PM -0400, Christoph Hellwig wrote:
> On Tue, Jul 19, 2011 at 11:24:50AM +1000, Dave Chinner wrote:
> > Honestly, I'd prefer not to do that because it's a slippery slope.
> > I've got plenty more "do stuff in the background via workqueues"
> > patches lined up, so if we start adding knobs/mount options to turn
> > each of them off "just in case there's an issue".
> > 
> > So far I haven't found any issues at all and I've been running this
> > split allocation stack like this in -all- my performance testing for
> > the past 2-3 months. I know that is not conclusive, but if the
> > bechmarks I've been using to improve XFS performance over the past
> > 18 months don't show regressions, that's fairly indicative of the
> > fact that most workloads won't even notice the change....
> 
> Maybe.  One thing I'd like to see is stuff like high-iop direct or
> O_SYNC I/O that actually calls the allocator.

What do you want me to run? I don't have any particularly high IOP
hardware here, but I might be able to do something that just hits
the BBWC....

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-19  3:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18  3:49 [PATCH 0/3] xfs: convert more code to use workqueues Dave Chinner
2011-07-18  3:49 ` [PATCH 1/3] xfs: introduce an allocation workqueue Dave Chinner
2011-07-18 16:00   ` Christoph Hellwig
2011-07-19  1:24     ` Dave Chinner
2011-07-19  2:02       ` Christoph Hellwig
2011-07-19  3:14         ` Dave Chinner [this message]
2011-07-18  3:49 ` [PATCH 2/3] xfs: convert xfsbufd to use a workqueue Dave Chinner
2011-07-18 16:01   ` Christoph Hellwig
2011-07-19  1:25     ` Dave Chinner
2011-07-18  3:49 ` [PATCH 3/3] xfs: flush the CIL via " Dave Chinner
2011-07-19  2:03   ` Christoph Hellwig
2011-07-19  3:05     ` Dave Chinner
2011-07-19  3:11       ` Christoph Hellwig
2011-07-19  4:28         ` Dave Chinner
2011-11-30  9:52   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110719031429.GM30254@dastard \
    --to=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox