From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p6J47PeU147053 for ; Mon, 18 Jul 2011 23:07:25 -0500 Received: from ipmail05.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 2FF6F11EFD44 for ; Mon, 18 Jul 2011 21:07:23 -0700 (PDT) Received: from ipmail05.adl6.internode.on.net (ipmail05.adl6.internode.on.net [150.101.137.143]) by cuda.sgi.com with ESMTP id CBFCRhQapB61nTi7 for ; Mon, 18 Jul 2011 21:07:23 -0700 (PDT) Date: Tue, 19 Jul 2011 14:07:21 +1000 From: Dave Chinner Subject: Re: [PATCH 0/2] splice: i_mutex vs splice write deadlock Message-ID: <20110719040721.GE31294@dastard> References: <1310961884-11634-1-git-send-email-david@fromorbit.com> <20110719031003.GA18166@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110719031003.GA18166@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com On Mon, Jul 18, 2011 at 11:10:03PM -0400, Christoph Hellwig wrote: > I don't really like this very much. Not taking the i_mutex at all > makes the splice_write method in XFS use different locking than > everyone else, and different from the normal XFS write path. > > For example ocfs2 which has the same locking issues just has an > own implementation of the splice_write method, which isn't > too nice but at least marginally better. I think the right > fix for both xfs and ocfs2 would be to have a generic_file_splice_write > variant that takes an "actor" function pointer, which defaults to > a smaller wrapper around file_remove_suid, file_update_time and > splice_from_pipe_feed, and then XFS and ocfs2 can provide their > own actors that add the additional locking. Yeah I thought about doing that, but wanted to try a simpler version first. I'll code up the actor variant. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs