public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: xfs: encapsulate a block of debug code
Date: Tue, 19 Jul 2011 13:10:28 -0400	[thread overview]
Message-ID: <20110719171028.GA31088@infradead.org> (raw)
In-Reply-To: <201107181814.p6IIEAZm028909@stout.americas.sgi.com>

On Mon, Jul 18, 2011 at 01:14:09PM -0500, Alex Elder wrote:
> Pull into a helper function some debug-only code that validates a
> xfs_da_blkinfo structure that's been read from disk.
> 
> Signed-off-by: Alex Elder <aelder@sgi.com>
> 
> ---
>  fs/xfs/xfs_da_btree.c |   31 ++++++++++++++++++++-----------
>  1 file changed, 20 insertions(+), 11 deletions(-)
> 
> Index: b/fs/xfs/xfs_da_btree.c
> ===================================================================
> --- a/fs/xfs/xfs_da_btree.c
> +++ b/fs/xfs/xfs_da_btree.c
> @@ -692,6 +692,24 @@ xfs_da_join(xfs_da_state_t *state)
>  	return(error);
>  }
>  
> +#ifdef	DEBUG
> +static void
> +xfs_da_blkinfo_validate(struct xfs_da_blkinfo *blkinfo, __u16 level)

I'm not sure the name is a good one.  E.g. the forw/backw pointers
really rely on this node not having any siblings.  Which they shoudn't
have here, but that's not generally true of any blkinfo.

Otherwise looks fine.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-07-19 17:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-18 18:14 xfs: encapsulate a block of debug code Alex Elder
2011-07-19 17:10 ` Christoph Hellwig [this message]
2011-07-19 19:49   ` Alex Elder
2011-07-24 11:30     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110719171028.GA31088@infradead.org \
    --to=hch@infradead.org \
    --cc=aelder@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox