Re: [PATCH 1/4] xfs: use a cursor for bulk AIL insertion

Alex Elder
2011-07-20T15:16:03Z

On Wed, 2011-07-20 at 09:36 +1000, Dave Chinner wrote:
> On Tue, Jul 19, 2011 at 06:03:44PM -0500, Alex Elder wrote:
> > On Mon, 2011-07-18 at 13:40 +1000, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > Delayed logging can insert tens of thousands of log items into the
> > > AIL at the same LSN. When the committing of log commit records
> > > occur, we can get insertions occurring at a
. . .
> _after_ which the new
> > * items should go. If lip is null the AIL was empty, so
> > * the new items go at the head of the AIL.
> > */
> > if (lip)
> > list_splice(list, &lip->li_ail);
> > else
> > list_splice(list, &ailp->xa_ail);
> > }
>
>
> Looks cleaner, but I'll need to test it. Right now all my test
> resources are busy with non-mainline stuff, so it's going to be next
> week sometime before I can do this.

I'll actually try to test this today. -Alex