Re: [PATCH 2/4] xfs: remove confusing ail cursor wrapper

Alex Elder
2011-07-19T23:03:55Z

On Mon, 2011-07-18 at 13:40 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> xfs_trans_ail_cursor_set() doesn't set the cursor to the current log
> item, it sets it to the next item. There is already a function for
> doing this - xfs_trans_ail_cursor_next() - and the _set function is
> simply a two line wrapper. Remove it and open code the setting of
> the cursor in the two locations that call it to remove the
> confusion.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

I already reviewed this but I do see you did a tiny change
or two. In any case, this (still) looks good.

Reviewed-by: Alex Elder <aelder@sgi.com>