From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p6KNDogI252614 for ; Wed, 20 Jul 2011 18:13:50 -0500 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 43C361809F79 for ; Wed, 20 Jul 2011 16:13:48 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id c95g5yKKJlFkYAnV for ; Wed, 20 Jul 2011 16:13:48 -0700 (PDT) Date: Thu, 21 Jul 2011 09:13:45 +1000 From: Dave Chinner Subject: Re: [PATCH] xfstests: fix modulo-by-zero error in fsx Message-ID: <20110720231345.GJ9359@dastard> References: <1311047353-23925-1-git-send-email-david@fromorbit.com> <1311203055.2906.75.camel@doink> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1311203055.2906.75.camel@doink> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: xfs@oss.sgi.com On Wed, Jul 20, 2011 at 06:04:15PM -0500, Alex Elder wrote: > On Tue, 2011-07-19 at 13:49 +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > The recent fsx fixes has a logic error in the offset trimming code. > > If a read is done when the file size is zero, then the logic error > > causes a offset % 0 opertaion to occur. This causes fsx to get a > > SIGFPE and die. > > > > This was not discovered during my testing because I was using a > > random seed that didn't trip this condition. Changing the seed to > > that which test 091 uses (the default of 1) causes such an operation > > to occur.... > > > > Signed-off-by: Dave Chinner > > I realize you already committed this, but I'm finally > getting around to reviewing it. > > I started composing this message, explaining how you > should have done something differently. But at this > point it'll be more constructive to just send a patch > against what you have already committed. So that will > be coming shortly... Yeah, better to have something working that perfect. Feel free to make it better ;) Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs