Re: [PATCH XFSPROGS 2/3] Build without enabling DEBUG by default

Christoph Hellwig
2011-07-26T15:10:38Z

On Fri, Jul 22, 2011 at 09:32:14PM -0400, Christoph Hellwig wrote:
> > diff --git a/include/builddefs.in b/include/builddefs.in
> > index 4c8ec64..81ebfcd 100644
> > --- a/include/builddefs.in
> > +++ b/include/builddefs.in
> > @@ -25,6 +25,7 @@ OPTIMIZER = @opt_build@
> > MALLOCLIB = @malloc_lib@
> > LOADERFLAGS = @LDFLAGS@
> > LTLDFLAGS = @LDFLAGS@
> > +CFLAGS = @CFLAGS@
> >
> > LIBRT = @librt@
> > LIBUUID = @libuuid@
> >
> > Then I don't have to set an environment variable when running make; I
> > just have to pass it to configure.
>
> This looks much better, and is indeed similar to some other fixes we
> recently had to put in, probably due to changing make behaviour.
>
> If you add a signoff and a proper description I'll put it into all the
> repositories.

Can you at least provide the signoff? I can take care of the rest if
this means I can get it in ASAP.