From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Chandra Seetharaman <sekharan@us.ibm.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 00/12 v3] Remove number of macros from xfs_buf.h
Date: Mon, 25 Jul 2011 16:26:38 -0400 [thread overview]
Message-ID: <20110725202638.GA18704@infradead.org> (raw)
In-Reply-To: <1311615418.2914.57.camel@doink>
On Mon, Jul 25, 2011 at 12:36:58PM -0500, Alex Elder wrote:
> I forgot to mention before that I got some
> feedback that removing these macros affects
> portability to other platforms (BSD specifically).
Personally I don't really like the way how the BSD port bolted the XFS
buffer use onto the BSD buffer cache. While the BSD buffer cache is
quite a bit closer to the original IRIX buffer cache model than the
Linux buffer cache, I think trying to reuse it is just as bad an idea as
partially using the Linux page cache. Russell might be able to chime
in on the current state of the FreeBSD XFS port, but last time I checked
it was in a pretty minimal state, thus not even exercising the nasty
sides of the buffer cache. If it wants to be full blown it should just
adadpt and use the current xfs_buf.c code, which really isn't that
Linux specific - sure it uses the Linux memory allocators, shrinkers
and the rbtree library, but it's a standalone piece of code with it's
own algorithms that have proven to be much better than the existing
generic OS buffer caches but catering to the specific XFS needs.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-07-25 20:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 23:39 [PATCH 00/12 v3] Remove number of macros from xfs_buf.h Chandra Seetharaman
2011-07-22 23:39 ` [PATCH 01/12 v3] xfs: Remove the macro XFS_BUF_BFLAGS Chandra Seetharaman
2011-07-22 23:39 ` [PATCH 02/12 v3] xfs: Remove the macro XFS_BUF_ZEROFLAGS Chandra Seetharaman
2011-07-24 11:39 ` Christoph Hellwig
2011-07-25 15:57 ` Alex Elder
2011-07-25 16:27 ` Christoph Hellwig
2011-07-25 17:07 ` Alex Elder
2011-07-25 17:09 ` Christoph Hellwig
2011-07-25 22:21 ` Chandra Seetharaman
2011-07-25 14:51 ` Alex Elder
2011-07-22 23:39 ` [PATCH 03/12 v3] xfs: Remove the macro XFS_BUF_ERROR and family Chandra Seetharaman
2011-07-24 11:40 ` Christoph Hellwig
2011-07-22 23:39 ` [PATCH 04/12 v3] xfs: Remove macro XFS_BUF_BUSY " Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 05/12 v3] xfs: Remove macro XFS_BUF_HOLD Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 06/12 v3] xfs: Remove macro XFS_BUF_SET_START Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 07/12 v3] xfs: Remove the macro XFS_BUF_PTR Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 08/12 v3] xfs: Remove the macro XFS_BUF_SET_PTR Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 09/12 v3] Replace the macro XFS_BUF_ISPINNED with helper xfs_buf_ispinned Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 10/12 v3] xfs: Remove the macro XFS_BUF_SET_TARGET Chandra Seetharaman
2011-07-24 11:41 ` Christoph Hellwig
2011-07-22 23:40 ` [PATCH 11/12 v3] xfs: Remove the macro XFS_BUF_TARGET Chandra Seetharaman
2011-07-22 23:40 ` [PATCH 12/12 v3] xfs: Remove the macro XFS_BUFTARG_NAME Chandra Seetharaman
2011-07-25 17:36 ` [PATCH 00/12 v3] Remove number of macros from xfs_buf.h Alex Elder
2011-07-25 20:26 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725202638.GA18704@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=sekharan@us.ibm.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox