From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH 1/3] xfs: flag all buffers as metadata
Date: Tue, 26 Jul 2011 11:06:44 -0400 [thread overview]
Message-ID: <20110726150644.GA18000@infradead.org> (raw)
In-Reply-To: <20110726150633.GA17400@infradead.org>
Now that REQ_META bios aren't treated specially in the CFQ I/O schedule
anymore, we can tag all buffers as metadata to make blktrace traces more
meaningful. Note that we use buffers also to zero out partial blocks
in the preallocation / hole punching code, and while they operate on
data blocks the zeros written certainly aren't data. I think this case
is borderline metadata enough to not bother special casing it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_buf.c 2011-07-25 23:50:03.288230279 +0200
+++ linux-2.6/fs/xfs/linux-2.6/xfs_buf.c 2011-07-25 23:50:22.208230167 +0200
@@ -1224,6 +1224,9 @@ _xfs_buf_ioapply(
rw = READ;
}
+ /* we only use the buffer cache for meta-data */
+ rw |= REQ_META;
+
next_chunk:
atomic_inc(&bp->b_io_remaining);
nr_pages = BIO_MAX_SECTORS >> (PAGE_SHIFT - BBSHIFT);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next parent reply other threads:[~2011-07-26 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110726150633.GA17400@infradead.org>
2011-07-26 15:06 ` Christoph Hellwig [this message]
2011-07-26 22:38 ` [PATCH 1/3] xfs: flag all buffers as metadata Alex Elder
2011-07-26 22:40 ` Christoph Hellwig
2011-07-26 22:41 ` Alex Elder
2011-07-26 15:07 ` [PATCH 2/3] xfs: prevent against ioend livelocks in xfs_file_fsync Christoph Hellwig
2011-07-26 22:39 ` Alex Elder
2011-07-26 15:07 ` [PATCH 3/3] xfs: optimize the negative xattr caching Christoph Hellwig
2011-07-26 22:39 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726150644.GA18000@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox