From: Christoph Hellwig <hch@infradead.org>
To: Ajeet Yadav <ajeet.yadav.77@gmail.com>
Cc: xfs@oss.sgi.com
Subject: Re: "xfs: fix error handling for synchronous writes" revisited
Date: Thu, 28 Jul 2011 10:50:20 -0400 [thread overview]
Message-ID: <20110728145020.GA30785@infradead.org> (raw)
In-Reply-To: <CAB4K4y6-2odbRhqn6q7ZDOxqF9oUcj2zKvyCEV6374QGyM-ddA@mail.gmail.com>
On Thu, Jul 28, 2011 at 04:21:01PM +0530, Ajeet Yadav wrote:
> Just to recall, last year we have reported one hang issue in 2.6.30.9
> wherein we get hang if we remove the device while synchronous write was underway
> It was because synchronous buffer remain locked in case of EIO error.
>
> In response to that a fix commit: bfc60177f8ab509bc225becbb58f7e53a0e33e81
> "xfs: fix error handling for synchronous writes" for 2.6.38 was given
> by community
> Unfortunately I did not use this patch and therefore did not test it.
>
> Coming to present, I run the same test case again, and I got different
> hang pasted below.
> While debugging I compared with my own solution, wherein I did not
> have any issue
> Kindly review the solution patch
Given that xfs_bwrite actually does the shutdown already after
waiting for the b_iodone completion this looks fine to me. And given
that we actually found that calling xfs_force_shutdown from inside
xfs_buf_iodone_callbacks was a major contributor the problem it looks
like an onversight that we didn't drop this call.
Can you re-send the patch with a proper changelog and signoff?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-07-28 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 10:51 "xfs: fix error handling for synchronous writes" revisited Ajeet Yadav
2011-07-28 14:50 ` Christoph Hellwig [this message]
2011-07-29 7:42 ` Ajeet Yadav
2011-08-10 10:09 ` Christoph Hellwig
2011-08-10 13:20 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110728145020.GA30785@infradead.org \
--to=hch@infradead.org \
--cc=ajeet.yadav.77@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox