From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: set cursor in xfs_ail_splice() even when AIL was empty
Date: Fri, 29 Jul 2011 20:56:39 +1000 [thread overview]
Message-ID: <20110729105639.GJ5404@dastard> (raw)
In-Reply-To: <201107212205.p6LM5dxF016460@stout.americas.sgi.com>
On Thu, Jul 21, 2011 at 05:05:39PM -0500, Alex Elder wrote:
> In xfs_ail_splice(), if a cursor is provided it is updated
> to point to the last item on the list to be spliced into
> the AIL. But if the AIL was found to be empty, the cursor
> (if provided) is just initialized instead.
>
> There is no reason the null AIL case needs to be any different.
> And treating it the same way allows this code to be rearranged
> a bit, with a somewhat tidier result.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
I've tested and reviewed the second version of this patch(*) and I
don't see anything problems at all, so:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
(*) In saving the second version, I accidentally marked the mail for
delete and then forgot to undelete it before switching mail folders
and commiting the delete. Hence I'm responding to the first mail :)
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-07-29 10:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 22:05 [PATCH] xfs: set cursor in xfs_ail_splice() even when AIL was empty Alex Elder
2011-07-22 14:24 ` Alex Elder
2011-07-29 10:56 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110729105639.GJ5404@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox