From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p72BPO6e099700 for ; Tue, 2 Aug 2011 06:25:24 -0500 Received: from mx2.suse.de (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5980A185E285 for ; Tue, 2 Aug 2011 04:25:22 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id f7sVhmnoWlDldjG2 for ; Tue, 02 Aug 2011 04:25:22 -0700 (PDT) Date: Tue, 2 Aug 2011 12:25:18 +0100 From: Mel Gorman Subject: Re: [PATCH 7/8] mm: vmscan: Immediately reclaim end-of-LRU dirty pages when writeback completes Message-ID: <20110802112518.GE10436@suse.de> References: <1311265730-5324-1-git-send-email-mgorman@suse.de> <1311265730-5324-8-git-send-email-mgorman@suse.de> <1311339228.27400.34.camel@twins> <20110722132319.GX5349@suse.de> <20110731152401.GE1735@barrios-desktop> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110731152401.GE1735@barrios-desktop> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Minchan Kim Cc: Rik van Riel , Jan Kara , Peter Zijlstra , LKML , XFS , Christoph Hellwig , Linux-MM , Wu Fengguang , Johannes Weiner On Mon, Aug 01, 2011 at 12:24:01AM +0900, Minchan Kim wrote: > On Fri, Jul 22, 2011 at 02:23:19PM +0100, Mel Gorman wrote: > > On Fri, Jul 22, 2011 at 02:53:48PM +0200, Peter Zijlstra wrote: > > > On Thu, 2011-07-21 at 17:28 +0100, Mel Gorman wrote: > > > > When direct reclaim encounters a dirty page, it gets recycled around > > > > the LRU for another cycle. This patch marks the page PageReclaim > > > > similar to deactivate_page() so that the page gets reclaimed almost > > > > immediately after the page gets cleaned. This is to avoid reclaiming > > > > clean pages that are younger than a dirty page encountered at the > > > > end of the LRU that might have been something like a use-once page. > > > > > > > > > > > @@ -834,7 +834,15 @@ static unsigned long shrink_page_list(struct list_head *page_list, > > > > */ > > > > if (page_is_file_cache(page) && > > > > (!current_is_kswapd() || priority >= DEF_PRIORITY - 2)) { > > > > - inc_zone_page_state(page, NR_VMSCAN_WRITE_SKIP); > > > > + /* > > > > + * Immediately reclaim when written back. > > > > + * Similar in principal to deactivate_page() > > > > + * except we already have the page isolated > > > > + * and know it's dirty > > > > + */ > > > > + inc_zone_page_state(page, NR_VMSCAN_INVALIDATE); > > > > + SetPageReclaim(page); > > > > + > > > > > > I find the invalidate name somewhat confusing. It makes me think we'll > > > drop the page without writeback, like invalidatepage(). > > > > I wasn't that happy with it either to be honest but didn't think of a > > better one at the time. nr_reclaim_deferred? > > How about "NR_VMSCAN_IMMEDIATE_RECLAIM" like comment rotate_reclaimable_page? > Yeah, I guess. I find it a little misleading because the reclaim does not happen immediately at the time the counter is incremented but it's better than "invalidate". -- Mel Gorman SUSE Labs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs