From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] xfsdump: convert to the POSIX signal API
Date: Thu, 4 Aug 2011 08:37:12 -0400 [thread overview]
Message-ID: <20110804123712.GA1089@infradead.org> (raw)
In-Reply-To: <4E3A91F8.3080606@sgi.com>
On Thu, Aug 04, 2011 at 07:35:04AM -0500, Bill Kendall wrote:
> Right, with some rework of that handler. It would have to do
> something like:
>
> case SIGINT:
> if (is_dialog_active(SIGINT))
> dlg_sigterm_received = BOOL_TRUE;
> else
> sigterm_received = BOOL_TRUE;
>
> (The SIGINT param is needed because it's optional whether a
> dialog handles a particular signal.)
>
> Otherwise we'd race between main's use of sigterm_received and
> the dialog's need to use it.
>
> Do you prefer this over the signal handler swap?
This seems cleaner to me. The upside is that we a) don't have
to mess with changing signal handlers all the time, and b)
that we don't really have to bother who is going to receive the
signal.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-08-04 12:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 20:40 [PATCH 0/4] xfsdump: convert to using the POSIX signal API Bill Kendall
2011-07-29 20:40 ` [PATCH 1/4] xfsdump: remove conditional OPENMASKED code Bill Kendall
2011-08-02 10:13 ` Christoph Hellwig
2011-08-02 14:07 ` Bill Kendall
2011-07-29 20:40 ` [PATCH 2/4] xfsdump: process EPIPE instead of catching SIGPIPE Bill Kendall
2011-08-02 10:15 ` Christoph Hellwig
2011-07-29 20:40 ` [PATCH 3/4] xfsdump: remove SIGCHLD handling Bill Kendall
2011-08-02 10:22 ` Christoph Hellwig
2011-08-02 14:13 ` Bill Kendall
2011-07-29 20:40 ` [PATCH 4/4] xfsdump: convert to the POSIX signal API Bill Kendall
2011-08-03 10:48 ` Christoph Hellwig
2011-08-03 10:56 ` Christoph Hellwig
2011-08-03 12:11 ` Bill Kendall
2011-08-03 12:39 ` Christoph Hellwig
2011-08-03 19:28 ` Bill Kendall
2011-08-04 7:53 ` Christoph Hellwig
2011-08-04 12:35 ` Bill Kendall
2011-08-04 12:37 ` Christoph Hellwig [this message]
2011-08-03 10:59 ` [PATCH 0/4] xfsdump: convert to using " Christoph Hellwig
2011-08-03 11:57 ` Bill Kendall
2011-08-03 12:02 ` Christoph Hellwig
2011-08-03 12:07 ` Bill Kendall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804123712.GA1089@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox