From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p79A74w7086349 for ; Tue, 9 Aug 2011 05:07:05 -0500 Received: from ipmail05.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 7ADE6C779E for ; Tue, 9 Aug 2011 03:07:02 -0700 (PDT) Received: from ipmail05.adl6.internode.on.net (ipmail05.adl6.internode.on.net [150.101.137.143]) by cuda.sgi.com with ESMTP id ZukvHDMSCEgyOytp for ; Tue, 09 Aug 2011 03:07:02 -0700 (PDT) Date: Tue, 9 Aug 2011 20:06:58 +1000 From: Dave Chinner Subject: Re: [PATCH] xfstests: fsx: fix fallocate logging Message-ID: <20110809100658.GQ3162@dastard> References: <1312818914-9950-1-git-send-email-josef@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1312818914-9950-1-git-send-email-josef@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Josef Bacik Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com On Mon, Aug 08, 2011 at 11:55:14AM -0400, Josef Bacik wrote: > I've been getting segfaults on fsx tests with btrfs because we're using the > wrong values for the logging with fallocate. We were using the numbers 1,2 and > 3 to indicate the type of preallocate we were doing, however we use these to > point to an array, so obviously array[3] for a 3 element array is wrong, so fix > these to do 0,1, and 2. Also spit out of we're using KEEP_SIZE in the log to > make it easier to figure out what's going on. Thanks, > > Signed-off-by: Josef Bacik Already fixed. http://git.kernel.org/?p=fs/xfs/xfstests-dev.git;a=commit;h=77c06202484237e26774efbd1774c251b6bef0a9 Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs