From: Christoph Hellwig <hch@infradead.org>
To: Ajeet Yadav <ajeet.yadav.77@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: "xfs: fix error handling for synchronous writes" revisited
Date: Wed, 10 Aug 2011 06:09:16 -0400 [thread overview]
Message-ID: <20110810100916.GA27094@infradead.org> (raw)
In-Reply-To: <CAB4K4y4Ns5woUJyPv_NuW0GYSb5ZcFkqnF-DxRB1MESibc1Knw@mail.gmail.com>
Looks good.
Alex, any chance to pick this one up for 3.1?
Reviewed-by: Christoph Hellwig <hch@lst.de>
On Fri, Jul 29, 2011 at 01:12:59PM +0530, Ajeet Yadav wrote:
> xfs: fix for hang during synchronous buffer write error
>
> If removed storage while synchronous buffer write underway,
> "xfslogd" hangs.
>
> Detailed log http://oss.sgi.com/archives/xfs/2011-07/msg00740.html
>
> Related work bfc60177f8ab509bc225becbb58f7e53a0e33e81
> "xfs: fix error handling for synchronous writes"
>
> Given that xfs_bwrite actually does the shutdown already after
> waiting for the b_iodone completion and given that we actually
> found that calling xfs_force_shutdown from inside
> xfs_buf_iodone_callbacks was a major contributor the problem
> it better to drop this call.
>
> Signed-off-by: Ajeet Yadav <ajeet.yadav.77@gmail.com>
>
> diff -Nurp -X linux/Documentation/dontdiff linux/fs/xfs/xfs_buf_item.c
> linux-Dirty/fs/xfs/xfs_buf_item.c
> --- linux/fs/xfs/xfs_buf_item.c 2011-06-09 10:05:18.000000000 +0530
> +++ linux-Dirty/fs/xfs/xfs_buf_item.c 2011-07-28 15:53:51.000000000 +0530
> @@ -1028,7 +1028,6 @@ xfs_buf_iodone_callbacks(
> XFS_BUF_UNDELAYWRITE(bp);
>
> trace_xfs_buf_error_relse(bp, _RET_IP_);
> - xfs_force_shutdown(mp, SHUTDOWN_META_IO_ERROR);
>
> do_callbacks:
> xfs_buf_do_callbacks(bp, lip);
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
---end quoted text---
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-08-10 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 10:51 "xfs: fix error handling for synchronous writes" revisited Ajeet Yadav
2011-07-28 14:50 ` Christoph Hellwig
2011-07-29 7:42 ` Ajeet Yadav
2011-08-10 10:09 ` Christoph Hellwig [this message]
2011-08-10 13:20 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110810100916.GA27094@infradead.org \
--to=hch@infradead.org \
--cc=ajeet.yadav.77@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox