From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7CKjucd086300 for ; Fri, 12 Aug 2011 15:45:57 -0500 Date: Fri, 12 Aug 2011 16:45:54 -0400 From: Christoph Hellwig Subject: Re: [PATCH v2 6/7] xfsdump: convert to the POSIX signal API Message-ID: <20110812204554.GA30615@infradead.org> References: <1312497011-24840-1-git-send-email-wkendall@sgi.com> <1312497011-24840-7-git-send-email-wkendall@sgi.com> <1313012883.2865.139.camel@doink> <4E457BEE.7060704@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4E457BEE.7060704@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Bill Kendall Cc: xfs@oss.sgi.com, aelder@sgi.com On Fri, Aug 12, 2011 at 02:15:58PM -0500, Bill Kendall wrote: > >Is there any requirement that the fields > >other than sa_flags and sa_handler should > >be zeroed before use? > > The sa_sigaction field will only be used if sa_flags > has SA_SIGINFO set, and the sa_restored field is obsolete > and not specified by POSIX. Better to explicitly initialize > everything though, so I'll change that. sigaction actuall is a rare case where this is harmful. To quote the manpage: On some architectures a union is involved: do not assign to both sa_handler and sa_sigaction. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs