From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7M69vla034740 for ; Mon, 22 Aug 2011 01:09:57 -0500 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 363EDFC214 for ; Sun, 21 Aug 2011 23:09:54 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id 2qhC31fFwndja186 for ; Sun, 21 Aug 2011 23:09:54 -0700 (PDT) Date: Mon, 22 Aug 2011 16:09:50 +1000 From: Dave Chinner Subject: Re: [PATCH 1/6] xfs: remove delwri buffer handling from xfs_buf_iorequest Message-ID: <20110822060950.GE3162@dastard> References: <20110814171517.174040686@bombadil.infradead.org> <20110814171651.707270455@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110814171651.707270455@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Sun, Aug 14, 2011 at 01:15:18PM -0400, Christoph Hellwig wrote: > We cannot ever reach xfs_buf_iorequest for a buffer with XBF_DELWRI set, > given that all write handlers make sure that the buffer is remove from > the delwri queue before, and we never do reads with the XBF_DELWRI flag > set (which the code would not handle correctly anyway). > > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs