From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7M6GQVB035039 for ; Mon, 22 Aug 2011 01:16:27 -0500 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A264313887A5 for ; Sun, 21 Aug 2011 23:18:58 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id V5ln23QHyzxOte68 for ; Sun, 21 Aug 2011 23:18:58 -0700 (PDT) Date: Mon, 22 Aug 2011 16:16:21 +1000 From: Dave Chinner Subject: Re: [PATCH 2/6] xfs: remove the unlock argument to xfs_buf_delwri_queue Message-ID: <20110822061621.GF3162@dastard> References: <20110814171517.174040686@bombadil.infradead.org> <20110814171651.889248041@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110814171651.889248041@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Sun, Aug 14, 2011 at 01:15:19PM -0400, Christoph Hellwig wrote: > We can just unlock the buffer in the caller, and the decrement of b_hold > would also be needed in the !unlock, we just never hit that case currently > given that the caller handles that case. > > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs