From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7M6WnVK035988 for ; Mon, 22 Aug 2011 01:32:49 -0500 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1D086FC691 for ; Sun, 21 Aug 2011 23:32:48 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id ODnds7UI9GE277Hk for ; Sun, 21 Aug 2011 23:32:48 -0700 (PDT) Date: Mon, 22 Aug 2011 16:32:45 +1000 From: Dave Chinner Subject: Re: [PATCH 1/5] xfs: remove dead ENODEV handling in xfs_destroy_ioend Message-ID: <20110822063245.GK3162@dastard> References: <20110814222412.359079843@bombadil.infradead.org> <20110814222517.607954695@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110814222517.607954695@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Sun, Aug 14, 2011 at 06:24:13PM -0400, Christoph Hellwig wrote: > No driver returns ENODEV from it bio completion handler, not has this > ever been documented. Remove the dead code dealing with it. > > Signed-off-by: Christoph Hellwig IIRC, this was added years ago for XVM to cause filesystems to shut down when the storage went away (e.g. someone tripped over a cable bundle or fenced the machine). It would be nice if there was some standard way of handling this rather than having the filesytem continue to allow applications to dirty memory when there is no chance of ever cleaning it.... As it is, I see no point in keeping something that won't ever be used, so Reviewed-by: Dave Chinner Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs