From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chris Pearson <kermit4@gmail.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] mkfs: reject emptry suboption arguments
Date: Mon, 22 Aug 2011 16:49:46 +1000 [thread overview]
Message-ID: <20110822064945.GR3162@dastard> (raw)
In-Reply-To: <20110815182415.GA30466@infradead.org>
On Mon, Aug 15, 2011 at 02:24:15PM -0400, Christoph Hellwig wrote:
> We require the argument to suboptions to not only exist, but also contain
> a non-empty string, as cvtnum can't handle empty strings properly. Also add
> the missing argument check to the -l agnum suboption which was lacking it.
>
> Reported-by: Chris Pearson <kermit4@gmail.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-08-22 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 18:24 [PATCH] mkfs: reject emptry suboption arguments Christoph Hellwig
2011-08-22 6:49 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822064945.GR3162@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=kermit4@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox