From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7M6nn28036746 for ; Mon, 22 Aug 2011 01:49:49 -0500 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5E0FF1388855 for ; Sun, 21 Aug 2011 23:52:21 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id A8R1m6S9f87TT8zl for ; Sun, 21 Aug 2011 23:52:21 -0700 (PDT) Date: Mon, 22 Aug 2011 16:49:46 +1000 From: Dave Chinner Subject: Re: [PATCH] mkfs: reject emptry suboption arguments Message-ID: <20110822064945.GR3162@dastard> References: <20110815182415.GA30466@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110815182415.GA30466@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: Chris Pearson , xfs@oss.sgi.com On Mon, Aug 15, 2011 at 02:24:15PM -0400, Christoph Hellwig wrote: > We require the argument to suboptions to not only exist, but also contain > a non-empty string, as cvtnum can't handle empty strings properly. Also add > the missing argument check to the -l agnum suboption which was lacking it. > > Reported-by: Chris Pearson > Signed-off-by: Christoph Hellwig Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs