From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/5] xfs: remove dead ENODEV handling in xfs_destroy_ioend
Date: Mon, 22 Aug 2011 10:27:46 -0400 [thread overview]
Message-ID: <20110822142746.GA24433@infradead.org> (raw)
In-Reply-To: <20110822063245.GK3162@dastard>
On Mon, Aug 22, 2011 at 04:32:45PM +1000, Dave Chinner wrote:
> On Sun, Aug 14, 2011 at 06:24:13PM -0400, Christoph Hellwig wrote:
> > No driver returns ENODEV from it bio completion handler, not has this
> > ever been documented. Remove the dead code dealing with it.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> IIRC, this was added years ago for XVM to cause filesystems to shut
> down when the storage went away (e.g. someone tripped over a cable
> bundle or fenced the machine). It would be nice if there was some
> standard way of handling this rather than having the filesytem
> continue to allow applications to dirty memory when there is no
> chance of ever cleaning it....
>
> As it is, I see no point in keeping something that won't ever be
> used, so
Initially I just made sure to defer contexts with ENODEV returns
to the workqueues as well, as we can't really shutdown the fs from
irq context. But given that this code is dead, and we are mixing
up positive and negative errors in io_error I decided it's better
to remove it for now.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-08-22 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 22:24 [PATCH 0/5] simply and speedup I/O completion handling Christoph Hellwig
2011-08-14 22:24 ` [PATCH 1/5] xfs: remove dead ENODEV handling in xfs_destroy_ioend Christoph Hellwig
2011-08-22 6:32 ` Dave Chinner
2011-08-22 14:27 ` Christoph Hellwig [this message]
2011-08-14 22:24 ` [PATCH 2/5] xfs: defer AIO/DIO completions Christoph Hellwig
2011-08-22 6:40 ` Dave Chinner
2011-08-22 14:28 ` Christoph Hellwig
2011-08-14 22:24 ` [PATCH 3/5] xfs: reduce ioend latency Christoph Hellwig
2011-08-22 6:43 ` Dave Chinner
2011-08-22 14:29 ` Christoph Hellwig
2011-08-14 22:24 ` [PATCH 4/5] xfs: wait for I/O completion when writing out pages in xfs_setattr_size Christoph Hellwig
2011-08-22 6:44 ` Dave Chinner
2011-08-14 22:24 ` [PATCH 5/5] xfs: remove i_iocount Christoph Hellwig
2011-08-22 6:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110822142746.GA24433@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox