From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH, RFC] xfs: deprecate the nodelaylog mount option
Date: Thu, 25 Aug 2011 10:10:39 +1000 [thread overview]
Message-ID: <20110825001039.GJ3162@dastard> (raw)
In-Reply-To: <20110824055750.GA11175@infradead.org>
On Wed, Aug 24, 2011 at 01:57:51AM -0400, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfs/Documentation/feature-removal-schedule.txt
> ===================================================================
> --- xfs.orig/Documentation/feature-removal-schedule.txt 2011-08-24 07:45:56.450196165 +0200
> +++ xfs/Documentation/feature-removal-schedule.txt 2011-08-24 07:47:17.049759519 +0200
> @@ -592,3 +592,11 @@ Why: In 3.0, we can now autodetect in
> interface that was used by acer-wmi driver. It will replaced by
> information log when acer-wmi initial.
> Who: Lee, Chun-Yi <jlee@novell.com>
> +
> +----------------------------
> +What: The XFS nodelaylog mount option
> +When: 3.3
> +Why: The delaylog mode that has been the default since 2.6.39 has proven
> + stable, and the old code is in the way of additional improvements in
> + the log code.
> +Who: Christoph Hellwig <hch@lst.de>
> Index: xfs/fs/xfs/xfs_super.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_super.c 2011-08-24 07:47:53.696227656 +0200
> +++ xfs/fs/xfs/xfs_super.c 2011-08-24 07:48:53.249238363 +0200
> @@ -356,6 +356,8 @@ xfs_parseargs(
> mp->m_flags |= XFS_MOUNT_DELAYLOG;
> } else if (!strcmp(this_char, MNTOPT_NODELAYLOG)) {
> mp->m_flags &= ~XFS_MOUNT_DELAYLOG;
> + xfs_warn(mp,
> + "nodelaylog is deprecated and will be removed in Linux 3.3");
> } else if (!strcmp(this_char, MNTOPT_DISCARD)) {
> mp->m_flags |= XFS_MOUNT_DISCARD;
> } else if (!strcmp(this_char, MNTOPT_NODISCARD)) {
No argument here. Getting rid of the old transaction commit code
would both siginficantly cleanup the code and enable lots of
interesting transaction optimisations to be made....
So it gets my thumbs-up.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-08-25 0:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 5:57 [PATCH, RFC] xfs: deprecate the nodelaylog mount option Christoph Hellwig
2011-08-25 0:10 ` Dave Chinner [this message]
2011-08-25 13:25 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825001039.GJ3162@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox