From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfsprogs: xfs_quota: don't double project block counts
Date: Thu, 25 Aug 2011 01:01:18 -0400 [thread overview]
Message-ID: <20110825050118.GC23901@infradead.org> (raw)
In-Reply-To: <e874ff01906d10e2ff4812b6badcc246f6a43af4.1314222483.git.aelder@sgi.com>
On Wed, Aug 24, 2011 at 04:53:42PM -0500, Alex Elder wrote:
> In projects_free_space_data() all of the block counts returned are
> doubled. This was probably a mistaken attempt to convert to or from
> 512-byte basic block units. The caller expects the value returned
> to be in 512-byte units, which is exactly what the fs_disk_quota
> structure holds, so there should be no doubling.
>
> The effect of this bug is that the disk space used by the "df"
> xfs_quota command shows block counts twice what they should be.
>
> SGI PV 1015651
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-08-25 5:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 21:53 [PATCH 0/3] xfsprogs: xfs_quota: a few fixes Alex Elder
2011-08-24 21:53 ` [PATCH 1/3] xfsprogs: xfs_quota: return real-time used data as intended Alex Elder
2011-08-24 21:53 ` [PATCH 2/3] xfsprogs: xfs_quota: don't double project block counts Alex Elder
2011-08-25 5:01 ` Christoph Hellwig [this message]
2011-08-24 21:53 ` [PATCH 3/3] xfsprogs: xfs_quota: improve calculation for percentage display Alex Elder
2011-08-25 5:02 ` Christoph Hellwig
2011-08-25 4:59 ` [PATCH 1/3] xfsprogs: xfs_quota: return real-time used data as intended Christoph Hellwig
2011-08-25 4:58 ` [PATCH 0/3] xfsprogs: xfs_quota: a few fixes Christoph Hellwig
2011-08-25 13:19 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825050118.GC23901@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox