From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7P51Kr5161940 for ; Thu, 25 Aug 2011 00:01:20 -0500 Date: Thu, 25 Aug 2011 01:01:18 -0400 From: Christoph Hellwig Subject: Re: [PATCH 2/3] xfsprogs: xfs_quota: don't double project block counts Message-ID: <20110825050118.GC23901@infradead.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: xfs@oss.sgi.com On Wed, Aug 24, 2011 at 04:53:42PM -0500, Alex Elder wrote: > In projects_free_space_data() all of the block counts returned are > doubled. This was probably a mistaken attempt to convert to or from > 512-byte basic block units. The caller expects the value returned > to be in 512-byte units, which is exactly what the fs_disk_quota > structure holds, so there should be no doubling. > > The effect of this bug is that the disk space used by the "df" > xfs_quota command shows block counts twice what they should be. > > SGI PV 1015651 > > Signed-off-by: Alex Elder Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs