From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: call mlog_exit in content_stream_restore
Date: Thu, 25 Aug 2011 01:03:26 -0400 [thread overview]
Message-ID: <20110825050326.GE23901@infradead.org> (raw)
In-Reply-To: <1313434763-22340-1-git-send-email-wkendall@sgi.com>
On Mon, Aug 15, 2011 at 01:59:23PM -0500, Bill Kendall wrote:
> This patch adds mlog_exit() calls to all the return paths in
> content_stream_restore(). mlog_exit() is supposed to be called before
> returning from content_stream_dump() and content_stream_restore(), but
> many paths in the latter did not do so, allowing for the stream exit
> status to be incorrect.
>
> Signed-off-by: Bill Kendall <wkendall@sgi.com>
Looks okay, but once again I'd prefer to use goto labels so that
we have a logical grouping of that required exit.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-08-25 5:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-15 18:59 [PATCH] xfsdump: call mlog_exit in content_stream_restore Bill Kendall
2011-08-25 5:03 ` Christoph Hellwig [this message]
2011-08-26 16:15 ` Alex Elder
2011-08-29 15:20 ` Bill Kendall
2011-09-02 13:57 ` Bill Kendall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110825050326.GE23901@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox