From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfs_repair: add printf format checking and fix the fallout
Date: Tue, 30 Aug 2011 15:22:26 +1000 [thread overview]
Message-ID: <20110830052226.GM3162@dastard> (raw)
In-Reply-To: <20110829083852.GA31515@infradead.org>
On Mon, Aug 29, 2011 at 04:38:52AM -0400, Christoph Hellwig wrote:
> ping?
>
> On Sun, Aug 14, 2011 at 04:12:39PM -0400, Christoph Hellwig wrote:
> > Add the gcc printf like attribute to the xfs_repair-internal logging helpers,
> > and fix the massive fallout. A large part of it is dealing with the correct
> > format for fixed size 64-bit types, but there were a lot of real bug in there,
> > including some that lead to crashed when repairing certain corrupted
> > filesystems on ARM based systems.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > Reported-by: Anisse Astier <anisse@astier.eu>
I see these new warnings after applying the patch on x86-64:
phase6.c: In function "shortform_dir_entry_check":
phase6.c:2737:4: warning: format "%llu" expects argument of type "long long unsigned int", but argument 3 has type "xfs_ino_t" [-Wformat]
phase6.c:2737:4: warning: format "%llu" expects argument of type "long long unsigned int", but argument 4 has type "xfs_ino_t" [-Wformat]
phase6.c: In function "shortform_dir2_entry_check":
phase6.c:3066:4: warning: format "%llu" expects argument of type "long long unsigned int", but argument 3 has type "xfs_ino_t" [-Wformat]
phase6.c:3066:4: warning: format "%llu" expects argument of type "long long unsigned int", but argument 4 has type "xfs_ino_t" [-Wformat]
The warnings do not appear on i686.
Otherwise, I've scanned the changes after checking what most of the
conversions are (e.g. %llu -> PRIU64 for inode numbers) and I didn't
see any obvious errors (but then again my eyes glazed over a bit
after the first 2000 lines of the patch). I haven't seen any runtime
changes, either, so if you fix the above warning as well, then
consider this:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-08-30 5:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-14 20:12 xfs_repair: add printf format checking and fix the fallout Christoph Hellwig
2011-08-29 8:38 ` Christoph Hellwig
2011-08-30 5:22 ` Dave Chinner [this message]
2011-08-30 8:57 ` Christoph Hellwig
2011-09-20 18:43 ` xfsprogs: fix some printf() warnings that show up for ia64 builds Alex Elder
2011-09-20 23:05 ` Dave Chinner
2011-09-21 2:02 ` Alex Elder
2011-09-19 22:39 ` xfs_repair: add printf format checking and fix the fallout Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110830052226.GM3162@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox