From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p7U6PZFo117362 for ; Tue, 30 Aug 2011 01:25:36 -0500 Received: from ipmail05.adl6.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 26DA41E7F3CF for ; Mon, 29 Aug 2011 23:25:34 -0700 (PDT) Received: from ipmail05.adl6.internode.on.net (ipmail05.adl6.internode.on.net [150.101.137.143]) by cuda.sgi.com with ESMTP id ujVx6F0BiPLkcQKf for ; Mon, 29 Aug 2011 23:25:34 -0700 (PDT) Date: Tue, 30 Aug 2011 16:25:32 +1000 From: Dave Chinner Subject: Re: [PATCH 2/2] xfs: fix ->write_inode return values Message-ID: <20110830062532.GO3162@dastard> References: <20110827055731.GA24159@infradead.org> <20110827055755.GB28351@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20110827055755.GB28351@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Sat, Aug 27, 2011 at 01:57:55AM -0400, Christoph Hellwig wrote: > Currently we always redirty an inode that was attempted to be written out > synchronously but has been cleaned by an AIL pushed internall, which is > rather bogus. Fix that by doing the i_update_core check early on and > return 0 for it. Also include async calls for it, as doing any work for > those is just as pointless. While we're at it also fix the sign for the > EIO return in case of a filesystem shutdown, and fix the completely > non-sensical locking around xfs_log_inode. > > Signed-off-by: Christoph Hellwig Makes sense. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs