From: "Arkadiusz Miśkiewicz" <arekm@maven.pl>
To: xfs@oss.sgi.com, aelder@sgi.com
Cc: Christoph Hellwig <hch@infradead.org>,
Sandeen <sandeen@redhat.com>,
Eric@oss.sgi.com, Boris Ranto <branto@redhat.com>
Subject: Re: xfstests 258: Test xfs fs creation with fs size close to 4 TB
Date: Wed, 21 Sep 2011 21:06:47 +0200 [thread overview]
Message-ID: <201109212106.48084.arekm@maven.pl> (raw)
In-Reply-To: <1316624075.2986.22.camel@doink>
On Wednesday 21 of September 2011, Alex Elder wrote:
> On Wed, 2011-09-21 at 15:52 +0200, Boris Ranto wrote:
> > mkfs.xfs failed to create xfs filesystems with 4 TB minus few bytes due
> > to round up error in mkfs.xfs code.
> >
> > This test case is a regression test for the fs creation problem.
> >
> > I've tested the test case with mkfs.xfs patch (in the form posted by
> > Eric Sandeen) and the test passed (and therefore the patch fixed the
> > issue for me).
> >
> > Signed-off-by: Boris Ranto <branto@redhat.com>
>
> This looks OK, but I'm a little concerned about the
> shell's ability to handle > 32-bit values in its
> arithmetic expressions (within $((...))).
>
> Using ${fourtb} works for me, but I just don't know
> whether it is written somewhere that bash always
> supports 64-bit (or even arbitrary) precision values.
I can say only that bashizm sux. posix shell unfortunately makes problems
here.
mksh (https://www.mirbsd.org/mksh.htm) supports 32bit arithmetic only (even on
64bit arch).
single unix spec says "signed long", so you cannot rely on posix shell for >
32bit values.
--
Arkadiusz Miśkiewicz PLD/Linux Team
arekm / maven.pl http://ftp.pld-linux.org/
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-21 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 13:52 xfstests 258: Test xfs fs creation with fs size close to 4 TB Boris Ranto
2011-09-21 16:54 ` Alex Elder
2011-09-21 19:06 ` Arkadiusz Miśkiewicz [this message]
2011-09-22 8:30 ` Boris Ranto
2011-09-22 16:30 ` Alex Elder
2011-09-26 11:44 ` Christoph Hellwig
2011-09-26 12:18 ` Alex Elder
2011-09-26 15:59 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109212106.48084.arekm@maven.pl \
--to=arekm@maven.pl \
--cc=Eric@oss.sgi.com \
--cc=aelder@sgi.com \
--cc=branto@redhat.com \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox