From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsdump: enable dump header checksums
Date: Thu, 22 Sep 2011 12:43:47 -0400 [thread overview]
Message-ID: <20110922164347.GA8686@infradead.org> (raw)
In-Reply-To: <1316537740.2912.25.camel@doink>
On Tue, Sep 20, 2011 at 11:55:40AM -0500, Alex Elder wrote:
> On Mon, 2011-09-19 at 19:18 -0500, Bill Kendall wrote:
> > On 09/19/2011 03:12 PM, Alex Elder wrote:
> . . .
> > > The theory in doing this unconditionally is that we might as
> > > well record it, even if the restore program chooses to ignore
> > > it, right?
> >
> > Right. (You probably noticed this also changes restore to
> > unconditionally verify the checksum, provided the flags
> > indicate the checksum was recorded.)
>
> It *might* be nice to have an option to ignore the
> checksum on restore. I don't know though. I was
> thinking it might be useful if whatever dumped the
> data did a buggy checksum but, well, we have no
> evidence that xfsdump has ever done that.
I think we really want this option before cutting a new release.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-09-22 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 21:41 [PATCH] xfsdump: enable dump header checksums Bill Kendall
2011-09-02 14:51 ` Gim Leong Chin
2011-09-02 15:02 ` Bill Kendall
2011-09-19 20:12 ` Alex Elder
2011-09-20 0:18 ` Bill Kendall
2011-09-20 16:55 ` Alex Elder
2011-09-22 16:43 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110922164347.GA8686@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox