From: Christoph Hellwig <hch@infradead.org>
To: Boris Ranto <branto@redhat.com>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfstests 258: Test xfs fs creation with fs size close to 4 TB
Date: Mon, 26 Sep 2011 07:44:58 -0400 [thread overview]
Message-ID: <20110926114458.GA1176@infradead.org> (raw)
In-Reply-To: <1316613160.781.8.camel@dhcp-26-208.brq.redhat.com>
This one actually fails for me in a 32-bit userspace VM:
--- 259.out 2011-09-26 09:14:39.000000000 +0000
+++ 259.out.bad 2011-09-26 11:22:44.000000000 +0000
@@ -1,7 +1,157 @@
QA output created by 259
Trying to make 4398046511103 B long xfs fs image
+dd failed
+can't get size of data subvolume
+Usage: mkfs.xfs
+/* blocksize */ [-b log=n|size=num]
...
When removing the dd output redirection thus turn into a:
+dd: failed to truncate to 4398046509056 bytes in output file `/259.image': File too large
As it turns out testfile is assigned to early in the test, and we thus
create the images on the root filesystem.
---
From: Christoph Hellwig <hch@lst.de>
Subject: [PATCH] xfstests: fix test 259
Move the assignment of testfile after the sourcing of the common.* files to
make sure TEST_DIR is already defined - without this we end up creating
the file on the root filesystem, which may not support large enough files.
Also add a sync after the mkfs.xfs invocation, as losetup -d might fail
the loop device deletion with -EBUSY otherwise.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/259
===================================================================
--- xfstests-dev.orig/259 2011-09-26 11:29:17.000000000 +0000
+++ xfstests-dev/259 2011-09-26 11:32:54.000000000 +0000
@@ -29,8 +29,6 @@ echo "QA output created by $seq"
status=1 # failure is the default!
-testfile=$TEST_DIR/259.image
-
_cleanup()
{
rm -f "$testfile"
@@ -45,6 +43,8 @@ trap "_cleanup ; exit \$status" 0 1 2 3
_supported_fs xfs
_supported_os Linux
+testfile=$TEST_DIR/259.image
+
# Test various sizes slightly less than 4 TB
# 4398046511103 = 2^42 - 1
# 4398046510592 = 2^42 - 512
@@ -63,6 +63,7 @@ do
lofile=$(losetup -f)
losetup $lofile "$testfile"
"$MKFS_XFS_PROG" -b size=512 $lofile >/dev/null || echo "mkfs failed!"
+ sync
losetup -d $lofile
done
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-26 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 13:52 xfstests 258: Test xfs fs creation with fs size close to 4 TB Boris Ranto
2011-09-21 16:54 ` Alex Elder
2011-09-21 19:06 ` Arkadiusz Miśkiewicz
2011-09-22 8:30 ` Boris Ranto
2011-09-22 16:30 ` Alex Elder
2011-09-26 11:44 ` Christoph Hellwig [this message]
2011-09-26 12:18 ` Alex Elder
2011-09-26 15:59 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926114458.GA1176@infradead.org \
--to=hch@infradead.org \
--cc=branto@redhat.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox