From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfsprogs: xfs_quota: kill local variable "type" from free_f()
Date: Thu, 29 Sep 2011 07:07:50 -0400 [thread overview]
Message-ID: <20110929110750.GC509@infradead.org> (raw)
In-Reply-To: <ccff8f308fbc7e15e9a74f28b5eb98490a0e3c82.1317210237.git.aelder@sgi.com>
On Wed, Sep 28, 2011 at 06:44:34AM -0500, Alex Elder wrote:
> Only one value is ever really used for the "type" variable in
> free_f(), and it indicates that either type of entry in fs_table
> is wanted. Just get rid of the variable and make use of the
> ability to provide 0 to free_space_list() to indicate that.
This sounds like someone planned to add an argument to it to support
looking at just normal or project quotas.
Given that it never materialized and no one asked for it I'm fine
with your cleanup.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-09-29 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 11:44 [PATCH 0/2] xfsprogs: libxcmd: support wildcard for fs_table lookups Alex Elder
2011-09-28 11:44 ` [PATCH 1/2] xfsprogs: libxcmd: allow 0 as a wildcard fs_table entry type selector Alex Elder
2011-09-28 11:44 ` [PATCH 2/2] xfsprogs: xfs_quota: kill local variable "type" from free_f() Alex Elder
2011-09-29 11:07 ` Christoph Hellwig [this message]
2011-09-29 11:06 ` [PATCH 1/2] xfsprogs: libxcmd: allow 0 as a wildcard fs_table entry type selector Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929110750.GC509@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox