Re: [PATCH 2/2] xfstest: fsstress add EXT2_IOC_{SET,GET}FLAGS operations

Christoph Hellwig
2011-09-18T20:03:02Z

On Sun, Sep 18, 2011 at 06:54:59PM +0400, Dmitry Monakhov wrote:
> Add two new operations:
> - getattr: ioctl(fd, EXT2_IOC_GETFLAGS, &fl)
> - setattr: ioctl(fd, EXT2_IOC_SETFLAGS, &random_flags)
> By default IOC_SET_SETFLAGS has zero probability because
> it may produce inodes with APPEND or IMMUTABLE flags which
> are not deletable by default. Let's assumes that one who
> enable it knows how to delete such inodes.
> For example like follows:
> find $TEST_PATH -exec chattr -i -a {} \;
> rm -rf $TEST_PATH

In general I like this, but:

- please provide a testcase actually using this new feature, and
- please don't require e2fsprogs just for the ioctl subcommands,
and use the FS_IOC_GET/SETFLAGS names provided by recent kernels
in fs.h instead. You might still need an ifdef for old kernels,
like src/t_immutable.c does. In fact it might be a good idea
to just provide the values for them if they aren't present in
a header shared by fsstress and t_immutable.c