From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p971jfeV212195 for ; Thu, 6 Oct 2011 20:45:41 -0500 Received: from ipmail07.adl2.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 920551B3B0B for ; Thu, 6 Oct 2011 18:45:39 -0700 (PDT) Received: from ipmail07.adl2.internode.on.net (ipmail07.adl2.internode.on.net [150.101.137.131]) by cuda.sgi.com with ESMTP id zXBkoLBwjyQiYWWI for ; Thu, 06 Oct 2011 18:45:39 -0700 (PDT) Date: Fri, 7 Oct 2011 12:45:36 +1100 From: Dave Chinner Subject: Re: [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale Message-ID: <20111007014536.GB3159@dastard> References: <20111006210607.175284390@bombadil.infradead.org> <20111006210639.352441913@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111006210639.352441913@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Thu, Oct 06, 2011 at 05:06:12PM -0400, Christoph Hellwig wrote: > For each call to xfs_buf_stale we call xfs_buf_delwri_dequeue either > directly before or after it, or are guaranteed by the surrounding > conditionals that we are never called on delwri buffers. Simply > this situation by moving the call to xfs_buf_delwri_dequeue into > xfs_buf_stale. Makes sense, and delwri-dequeue is safe to call on non-delwri buffers. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs