From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 7/9] xfs: clean up xfs_ioerror_alert
Date: Fri, 7 Oct 2011 10:17:59 -0400 [thread overview]
Message-ID: <20111007141759.GA7948@infradead.org> (raw)
In-Reply-To: <20111007015441.GD3159@dastard>
On Fri, Oct 07, 2011 at 12:54:41PM +1100, Dave Chinner wrote:
> Only thing I'm wondering about is whether is should be renamed
> xfs_buf_ioerror_alert(), now that it really is a xfs_buf specific
> function?
That probably is a better name. There are a few other functions in the
buffer code that are misnamed like that e.g. xfs_incore and to a lesser
extent xfs_bwrite or XFS_bflush.
> Also, many of the callers could probably pass __func__ rather than a
> manually set string...
True.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-07 14:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 21:06 [PATCH 0/9] a couple of buffer cache cleanups Christoph Hellwig
2011-10-06 21:06 ` [PATCH 1/9] xfs: remove xfs_get_buftarg_list Christoph Hellwig
2011-10-07 1:38 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 2/9] xfs: remove XFS_BUF_FINISH_IOWAIT Christoph Hellwig
2011-10-07 1:38 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 3/9] xfs: remove XFS_BUF_SET_VTYPE and XFS_BUF_SET_VTYPE_REF Christoph Hellwig
2011-10-07 1:40 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 4/9] xfs: remove XFS_BUF_STALE and XFS_BUF_SUPER_STALE Christoph Hellwig
2011-10-07 1:41 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 5/9] xfs: remove buffers from the delwri list in xfs_buf_stale Christoph Hellwig
2011-10-07 1:45 ` Dave Chinner
2011-10-07 19:36 ` Alex Elder
2011-10-06 21:06 ` [PATCH 6/9] xfs: clean up buffer allocation Christoph Hellwig
2011-10-07 1:48 ` Dave Chinner
2011-10-07 19:37 ` Alex Elder
2011-10-06 21:06 ` [PATCH 7/9] xfs: clean up xfs_ioerror_alert Christoph Hellwig
2011-10-07 1:54 ` Dave Chinner
2011-10-07 14:17 ` Christoph Hellwig [this message]
2011-10-07 19:37 ` Alex Elder
2011-10-06 21:06 ` [PATCH 8/9] xfs: use xfs_ioerror_alert in xfs_buf_iodone_callbacks Christoph Hellwig
2011-10-07 1:55 ` Dave Chinner
2011-10-07 19:37 ` Alex Elder
2011-10-06 21:06 ` [PATCH 9/9] xfs: remove xfs_buf_target_name Christoph Hellwig
2011-10-07 1:57 ` Dave Chinner
2011-10-07 19:37 ` Alex Elder
2011-10-07 20:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111007141759.GA7948@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox