From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p99NjXJP132379 for ; Sun, 9 Oct 2011 18:45:34 -0500 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 3B73A1C79879 for ; Sun, 9 Oct 2011 16:45:30 -0700 (PDT) Received: from bombadil.infradead.org (173-166-109-252-newengland.hfc.comcastbusiness.net [173.166.109.252]) by cuda.sgi.com with ESMTP id aZkzfr2Drce97Qq6 for ; Sun, 09 Oct 2011 16:45:30 -0700 (PDT) Date: Sun, 9 Oct 2011 19:45:29 -0400 From: Christoph Hellwig Subject: Re: [PATCH 2/5] repair: fix some valgrind reported errors on i686 Message-ID: <20111009234529.GA13527@infradead.org> References: <1318201910-11144-1-git-send-email-david@fromorbit.com> <1318201910-11144-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1318201910-11144-3-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, Oct 10, 2011 at 10:11:47AM +1100, Dave Chinner wrote: > From: Dave Chinner > > Fix a potential prefetch read problem due to the first loop > execution of pf_batch_read potentially not initialising the fsbno > varaible: variable. > > ==10177== Thread 6: > ==10177== Conditional jump or move depends on uninitialised value(s) > ==10177== at 0x8079CAB: pf_batch_read (prefetch.c:408) > ==10177== by 0x6A2996D: clone (clone.S:130) > ==10177== > > Signed-off-by: Dave Chinner > --- > repair/prefetch.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/repair/prefetch.c b/repair/prefetch.c > index d2fdf90..da074a8 100644 > --- a/repair/prefetch.c > +++ b/repair/prefetch.c > @@ -397,7 +397,7 @@ pf_batch_read( > int len, size; > int i; > int inode_bufs; > - unsigned long fsbno; > + unsigned long fsbno = 0; Call me stupid, but I can't see how this could actually be a real life issue. The first thing we do in the loop is to to write to fsbno in btree_find. I'm fine adding this to shut up warnins, but I can't see a real issue. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs