Re: [PATCH 2/4] xfs: force the log if we encounter pinned buffers in .iop_pushbuf

Alex Elder
2011-10-07T22:18:15Z

On Thu, 2011-10-06 at 14:32 -0400, Christoph Hellwig wrote:
> We need to check for pinned buffers even in .iop_pushbuf given that inode
> items flush into the same buffers that may be pinned directly due operations
> on the unlinked inode list operating directly on buffers. To do this add a
> return value to .iop_pushbuf that tells the AIL push about this and use
> the existing log force mechanisms to unpin it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reported-by: Stefan Priebe <s.priebe@profihost.ag>
> Tested-by: Stefan Priebe <s.priebe@profihost.ag>

Looks ok to me.

Reviewed-by: Alex Elder <aelder@sgi.com>