From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems
Date: Tue, 11 Oct 2011 13:11:32 +1100 [thread overview]
Message-ID: <20111011021132.GA3159@dastard> (raw)
In-Reply-To: <20111010182233.GB1335@infradead.org>
On Mon, Oct 10, 2011 at 02:22:33PM -0400, Christoph Hellwig wrote:
> The tests in 091 are entirely generic and pass e.g. on ext4 and jfs.
> btrfs fails it, but that looks a like a btrfs-specific issue to me.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfstests-dev/091
> ===================================================================
> --- xfstests-dev.orig/091 2011-10-10 18:09:20.000000000 +0000
> +++ xfstests-dev/091 2011-10-10 18:09:41.000000000 +0000
> @@ -37,7 +37,7 @@ trap "rm -f $tmp.*; exit \$status" 0 1 2
> . ./common.filter
>
> # real QA test starts here
> -_supported_fs xfs
> +_supported_fs generic
> _supported_os Linux IRIX
>
> [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"
Given that the test is not run on irix, I'd change the _supported_os
line to just Linux as well, and kill the separate check for Irix
while you are there.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-10-11 2:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 18:21 [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Christoph Hellwig
2011-10-10 18:22 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Christoph Hellwig
2011-10-10 18:22 ` [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems Christoph Hellwig
2011-10-11 2:11 ` Dave Chinner [this message]
2011-10-11 12:46 ` Christoph Hellwig
2011-10-11 14:18 ` [PATCH 3/3 v2] " Christoph Hellwig
2011-10-11 22:40 ` Dave Chinner
2011-10-13 11:06 ` Alex Elder
2011-10-11 22:40 ` [PATCH 2/2] xfstests: split mapped writes vs direct I/O tests from 091 Dave Chinner
2011-10-12 7:32 ` Christoph Hellwig
2011-10-13 11:06 ` Alex Elder
2011-10-13 11:06 ` Alex Elder
2011-10-11 22:36 ` [PATCH 1/3] xfstests: fix 122 for recent xfsprogs Dave Chinner
2011-10-13 11:06 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011021132.GA3159@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox