Re: [PATCH 3/3] xfstests: allow 091 for non-xfs filesystems

Dave Chinner
2011-10-11T02:11:36Z

On Mon, Oct 10, 2011 at 02:22:33PM -0400, Christoph Hellwig wrote:
> The tests in 091 are entirely generic and pass e.g. on ext4 and jfs.
> btrfs fails it, but that looks a like a btrfs-specific issue to me.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Index: xfstests-dev/091
> ===================================================================
> --- xfstests-dev.orig/091 2011-10-10 18:09:20.000000000 +0000
> +++ xfstests-dev/091 2011-10-10 18:09:41.000000000 +0000
> @@ -37,7 +37,7 @@ trap "rm -f $tmp.*; exit \$status" 0 1 2
> . ./common.filter
>
> # real QA test starts here
> -_supported_fs xfs
> +_supported_fs generic
> _supported_os Linux IRIX
>
> [ $HOSTOS == IRIX ] && _notrun "Not working on IRIX yet"

Given that the test is not run on irix, I'd change the _supported_os
line to just Linux as well, and kill the separate check for Irix
while you are there.

Cheers,

Dave.

--
Dave Chinner
david@fromorbit.com